Yobai wrote on Jul 9^th, 2015 at 5:45pm:


A friend proficient in these things showed me what was in the game Data files.
The devs leave comments in files they know can be cracked.
And the comments are really stupid and unprofessional.

You can't tell who wrote stuff, but it is pretty telling of the general work ethic and accepted standard of coding.

DropBear wrote on Jul 9^th, 2015 at 8:16pm:

I want a list. Extra bonus points if you can get the Crystal Cove kobolds to read them.

Will do when I get a chance.  On my phone at the moment.

DropBear wrote on Jul 9^th, 2015 at 9:22pm:


C'mon. We're still waiting.

Ok, you impatient bastards, here's what I could find.

This in the Deathwyrm code:

?)We shut this off, hopefully for a reason.
Prevents multikick - Is initially set from KickOut. Works REGARDLESS of whether or not she finds a target, so as to not, oh, crash the server.
?DAt this point, the Phylactery is destroyed, and she can be defeated.C
Turn on the target zone.\
[...]
?aTHIS IS SPECIAL SNOWFLAKE FOR AURG! I have nuked her flight scripts in favor of Shadow-summoning.w
[...]
?>REMOVED BECOME_MONSTER FOR DRAMA REASONS - Trigger it yerself!
[...]
?XYou KO'd the Dragon while her Phylactery still stands. Good job, but it got you nowhere.|
trigger_52C
I CAN HAZ TARGETS?}
[...]
?LThis is a debug script - it should make the Dragons super-hate test kobolds.
hate_spell
??This command is specific to Aurg, and shuffles the Spell Traps.
Command
dragon_to_trapgen
lolth_screams2C
?*Placeholder, replace with appropriate text*
trigger_45C
trigger_44C
?TLasers are being fired. Am I OK to die now? (Needs a check for all 8 Repaired beams)r
[...]
?+HOLD THE DANG PHONE THEY JUST BEAT THE RAIDy
dragon_to_indicator
dragon_to_indicator
dragon_to_indicator
dragon_to_indicator
get initialized after properties, startup scripts are a special case and are run before properties are initialized. If we don't have this short delay, it will trigger the transition again if this object is re-created from scratch on a player's client.
[...]
 

Some other misc stuff.

This is the conversation space. There's lots of space. Ken Troop owes me money. I let him think he paid me back, but he still owes. One day, I'm going to collect. In blood. Unless he pays homage to me in the backstory.
This is the title.
This is Option 1. It's the longest option, and it's really just here to get an idea of how much space we have to work with. This is probably way too long, but hey, this is for testing.
This is Option 2
This is Option 3... OAAAKKKSTTAAAAAFFF!!!

[...]
Certain combat styles aren't implemented, notably:  unarmed, bow, axe

[...]

This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining
ie bonus mutation alongside it.
This is a safety valve to keep some old weapon
from keeping it plus gaining a new die bonus mutation alongside it.V
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons
rom keeping it plus gaining a new die bonus mutation alongside it.e
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.}
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons

[...]

Cheater check - Put a slow on characters who have equipped item above min level
Make sure players don't get stuck with this effect accidentally.

[...]

Set off cooldown on Weapon Bond activated ability.
but this does prevent some possible exploits (where you could get multiple of these, which isn't intended.x

[...]
Mix of old and new enhancements.
FIX ME!
[...]
VOH HEY that other thing was a lie. Rogue Mechanics get Great Crossbow proficiency now.
[...]
Scales are weird as heck because of the collisiony things needed for Challenges. Don't mess with them.$
[...]
Armor goes through different scripts (because armor appearances are applied to the wielder, and weapons apply it to themselves!) . Appearance file is set in the weapon entity, and modifier is set in the cdb.
[...]
Your weapons be invisible in wolf form! Yeah!
For when our equipper is invisible / camoflauged / etc.
Cheater check - Put a slow on characters who have equipped item above min level
Make sure players don't get stuck with this effect accidentally.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.;B
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.j@
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.%?
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.T=
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.M:
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.68
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.k1
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.50
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.U.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.N+
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.})
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.N(
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.f'
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.T
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.

This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
This is a safety valve to keep some old weapons that shouldn't have this effect any longer from keeping it plus gaining a new die bonus mutation alongside it.
[...]
This should maybe be deeper in for performance.
These don't REALLY have to be nested, but this does prevent some possible exploits where you could get multiple of these, which isn't intended.
[...]
This is dumb, but it's a separate switch for Enraged Nicely.
[...]
Delay for race condition prevention
[...]
DON'T DO THIS
If we ever intentionally resurrect Ice Pyramid Rat Rugby, maybe put this back.  But we don't want banked rats to infest again.
[...]
http://wbnet/addpoints/soap
http://wbnet/addpoints/complete
http://wbnet/addpoints
[...]
I'm a naked pet!
[...]
This does a shot + the dead zone delay - the reload animation.  NOTE:  DO NOT CHANGE THE DEAD ZONE DELAY without visiting the FeatTable.cdb and adjusting the base cooldown time for cooldown timer #2.
Make sure the player has ammo equpped.
FIXME:  we aren't actually checking that this is a compatable type of ammo for my weapon!
Make sure the player has ammo equpped.
FIXME:  we aren't actually checking that this is a compatable type of ammo for my weapon!
Make sure the player has ammo equpped.
FIXME:  we aren't actually checking that this is a compatable type of ammo for my weapon!*
Make sure the player has ammo equpped.
FIXME:  we aren't actually checking that this is a compatable type of ammo for my weapon!
Make sure the player has ammo equpped.
FIXME:  we aren't actually checking that this is a compatable type of ammo for my weapon!z
OnDeliver
Reloading a weapon only (presumably for the equip action should take the same amount of time it should take to fire and reload that weapon).  NOTE:  DO NOT CHANGE THE DEAD ZONE DELAY without visiting the FeatTable.cdb and adjusting the base cooldown time for cooldown timer #2.
?CThis number is NOT arbitrary.  It is = 0.3 + fire animation time.
Bow shot animation + dead zone delay (0.3) + reload animation.  NOTE:  DO NOT CHANGE THE DEAD ZONE DELAY without visiting the feattable.cdb and adjusting the base cooldown time for cooldown timer #2.
[...]
 

I'm not a coder, so I don't understand the intricacies of all it so this was parsed for my benefit, but my friend commented, "It seems they never clean up the code, they just keep adding to it, moving the entry points to new code and keeping the old one present."

I don't have access to the code, so don't ask me for it.
Hacking dat files is not my skillset sorry.   

DropBear wrote on Jul 10^th, 2015 at 3:42am:



...



Make sure players don't get stuck with this effect accidentally.

Make sure players don't get stuck with this effect accidentally.

Quote:

Dafuq. Secret Pacman level ?

DropBear wrote on Jul 10^th, 2015 at 3:42am:


Some are old for sure. Ken Troop seems to have worked for Turbine between 2000 - 2006 and then moved on to Wizards of the Coast.

Quote:

Hiding wrote on Jul 10^th, 2015 at 4:38am:


Nah, it's probably not the only reason.... If you look in The Vault Archives you'll see some posts made a few years ago ( after Rodrak event ) that gives hints at the file structure...
and from what was said then it seems that old code gets 'neutered' but stay in the files... and from time to time there's a failed call that points towards that neutered code.

Like when EVON1 was gining EGH Chain reward : Typically the call for the EVON1 Loot Table was sending the game towards EGH Chain loot table.
( and the EVON1 Loot table was neutered at that time )

Wow. Those comments in DeathWyrm are mind blowing. A junior dev who committed stuff like that into source control would get a serious talking to. It just shows a complete lack of professionalism and pride in your work.

As someone who graduated with a programming degree and is actively trying to become a professional coder... I pray that I never have to work on something like DDO's sourcecode. It might convince me to swap to a new career.

More stupid shit made by drunk devs:



Yes, that is an actual picture of a real map that exists in the game, and no I have no fucking clue what it's supossed to be.

Some Guy Here On The Boards wrote on Jul 13^th, 2015 at 6:05pm:


I'm not against a bit of humor at work, but that code is a workspace and it should be kept as clean as possible.  Save the humor for the PacMan Larp zone or Friday night beverages.

For example, for the post above, I had to delete several hundred rows of "This is safety valve...." variations.
Haven't they heard of "ditto"?

I believe the problem is a psychological one.
The same behaviors are observable in the work kitchen space.
As soon as anyone leaves a dirty spoon, cup or plate, there is a cascade of shit left there because people feel "someone else did it, so it's ok".  I've been quite amazed that even when people know the expectation is to clean your own stuff, that one person failing
suddenly sees everyone break behavior and become lazy asses.

The source code would be the same.  Why would a new programmer/dev bother trying to be neat when all of the visible material around him is unregulated crap?

I've inherited legacy systems in my previous life as a systems guy.  Fixing legacy systems is a PITA, but if an upgrade/replacement is not an option, then it needs to be done right.
You have a choice, operate it and leave it alone and blame the "other guy" for all the bugs and issues, and hope you don't get fired for it.

Or you get your hands dirty and own it.
You don't touch it till you know what you're doing, and you don't normally flaff around the edges - you start at the core and work out (depending on your timeframe and interest).
You change it and make it yours - no excuses "but the previous guy did that BS".  Having bothered to change it, you then structure it in a clean, logical way that future systems people can follow it, understand it and maintain it.

To my mind, its simply about taking pride in your work.  I get it, the Turdbine devs are overworked and underpaid, but someone has to bite the bullet before the system implodes.

Some queries for those proficient in game design and programming.
Surely the DDO sourcecode can be broken into modules for specific functions?  Break out all the extraneous functions like Crafting, TR'ing, Guilds, AH/ASAH, Traders/turn-ins, Feat swaps, etc and focus the source code on the actual game functions?

For example, things like the Cannith Crafting systems should be a separate module that only is called and released as needed (thus saving memory and overheads), and can be maintained without impacting the rest of the game?
Seriously, how hard can recipes be?
We do some DB work in my business, and my guys can set up many tables collating all the related data separately and call upon the tables as needed.  It makes maintenance and analysis so much easier seeing like data/functions together. 

Wouldn't crafting recipes just be an entry in a DB table?
You standardize the code for all the parameters - bound/unbound, ML, pre-reqs etc and then make calls on the DB tables?

Same for loot tables?  Have a central set of general loot tables that are called upon.  So when they decide to change loot, you don't have to change it in 45 places.

Monsters?  Shouldn't they be stored in a Monsters table?  Bosses and raid bosses with specific behaviours might be different.
This would make coding and tracking monster types in the MM easier.
All the core info on a Monster - it's stats, resistances, AI behaviour, animations, skins etc could be in a central repository.  Each content (quest) could then call and modify it as required. 

And with the right toolset, you should be able to see the linkages between code and tables so that when you make a change, you know what it is going to effect?

This type of work would be hard in the early days of a game as you're adding new systems and functionality all the time - but in a mature game like DDO, you have or know most of your systems, so do the work to change it knowing you can see the big picture.  If you think legendary weapons are possible, allow flexibility for it.  That's the reason for having a plan/strategy - you have some idea what you would like to do, time and budget permitting.

Interested to hear your thoughts.